[
https://issues.apache.org/jira/browse/HTRACE-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645584#comment-14645584
]
Masatake Iwasaki commented on HTRACE-222:
-----------------------------------------
Thanks Colin.
{code}
141 LOG.info("WATERMELON: addRef to " + receiver);
{code}
Is this debug message?
{code}
112 protected synchronized void removeReceiver(SpanReceiver receiver) {
113 if (receivers.remove(receiver)) {
114 SpanReceiverPool.INSTANCE.addReference(receiver);
115 }
{code}
{{SpanReceiverPool.INSTANCE.removeReference}} should be called here.
bq. Note that we don't get any benefit from this without the rest of the
HTRACE-214 change
I think it is ok to leave SpanReceiverPool unused at this stage.
> Add SpanReceiverPool
> --------------------
>
> Key: HTRACE-222
> URL: https://issues.apache.org/jira/browse/HTRACE-222
> Project: HTrace
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-222.001.patch
>
>
> Add SpanReceiverPool, a pool of span receivers which can be used by multiple
> Tracer objects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
