[
https://issues.apache.org/jira/browse/HTRACE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945996#comment-14945996
]
Colin Patrick McCabe commented on HTRACE-237:
---------------------------------------------
Thanks for reviewing.
bq. So, updating htrace, a 4.0.1 won't be able to write a 4.1? Can we not do
both?
Hmm. I think it's a lot of effort to maintain both, and not worth it. It
should be fine to specify that the SpanReceiver version has to match the
htraced version for now. Remember that we are manually adding the SpanReceiver
to the classpath so we can add whatever we want without updating downstream.
bq. But we are going against HTraceConfiguration Interface, not Hadoop
Configuration? We can do whatever we want int he Implementation? Cache?
I think there are a lot of advantages to putting the configuration stuff into
{{Conf.java}}. It's nice to have a place to put all the functions for parsing
a comma-separated list, or parsing a host:port pair. It feels cleaner to put
this in a separate file than to stuff it all into the {{SpanReceiver.java}}. I
like the fact that we can log the exact configuration that is being used... I
think that will be very helpful in the field. The JVM can optimize access to
the configuration variables since they are now {{final}} and it knows they
can't change. We are insulated from race conditions and other issues if
someone changes a {{Hadoop Configuration}} object (they are mutable after all).
I think this is pretty similar to what we do in other span receivers as well,
except that they put the configuration variables directly into their class,
whereas we put them into {{Conf.java}}
bq. Ok. {{htraced.receiver.packed}} is doc'd? Release note at least.
Yeah, I need to write some more documentation about the various configuration
keys. That might be good in a follow-on?
> Optimize htraced span receiver
> ------------------------------
>
> Key: HTRACE-237
> URL: https://issues.apache.org/jira/browse/HTRACE-237
> Project: HTrace
> Issue Type: Improvement
> Affects Versions: 4.1
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-237.001.patch, HTRACE-237.002.patch,
> HTRACE-237.003.patch, HTRACE-237.004.patch
>
>
> Optimize htraced span receiver so that it supports double buffering and both
> the msgpack and REST transports.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
