[
https://issues.apache.org/jira/browse/HTRACE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952659#comment-14952659
]
stack commented on HTRACE-237:
------------------------------
Says HTracedBuffer in BufferManager... might be old name for the class? And
regards the thread-safe comment, isn't it in the implementation where you say
if it is thread-safe or not? What is to stop me implementing a thread-safe
buffer?
prepare in the buffermanager seems like TMI clear is reset... drop all
contents and start over?
Conf needs explanation as to what it is especially given it is importing
HTraceConfiguration.
You want to say anything in comment on why you have the two buffers, one
flushing while other is being written to?
Otherwise +1 on the patch. Has a bit of testing. Good.
> Optimize htraced span receiver
> ------------------------------
>
> Key: HTRACE-237
> URL: https://issues.apache.org/jira/browse/HTRACE-237
> Project: HTrace
> Issue Type: Improvement
> Affects Versions: 4.1
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-237.001.patch, HTRACE-237.002.patch,
> HTRACE-237.003.patch, HTRACE-237.004.patch
>
>
> Optimize htraced span receiver so that it supports double buffering and both
> the msgpack and REST transports.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
