[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253122#comment-15253122
]
Colin Patrick McCabe commented on HTRACE-359:
---------------------------------------------
Hi [~mdrob],
Thanks for the patch. Looks good overall.
One small note: It's a bit confusing to upload multiple patch files with the
same name... usually we add numbers to the end to make sure that the correct
patch gets committed.
{code}
- public TraceRunnable(Tracer tracer, TraceScope parent,
+ public TraceRunnable(Tracer tracer, SpanId parentId,
{code}
Hmm, we have to be careful here. We can't change the type signature of a
public htrace4-core API. It breaks our compatibility guidelines. If you
haven't read them yet, please check out the compatibility policy here:
http://markmail.org/message/g4t4aivhvi2yyuqq On the other hand, we can add a
new constructor with the type signature that includes {{SpanId}}.
> TraceRunnable and TraceCallable should be built using parent spanId not scope
> -----------------------------------------------------------------------------
>
> Key: HTRACE-359
> URL: https://issues.apache.org/jira/browse/HTRACE-359
> Project: HTrace
> Issue Type: Bug
> Components: core
> Affects Versions: 4.0
> Reporter: Mike Drob
> Assignee: Mike Drob
> Attachments: HTRACE-359.patch.txt, HTRACE-359.patch.txt
>
>
> TraceRunnable/Callable both take a parent TraceScope and extract the span Id
> from it when executing the task. Instead, we should allow users to create
> custom TraceRunnable/Callable instances with only a SpanId instead of a full
> TraceScope, for instance when reading a span id from an RPC call and a
> TraceScope object is not available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
