[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259078#comment-15259078
]
Colin Patrick McCabe commented on HTRACE-359:
---------------------------------------------
Ha! That's a fair criticism. Adding the new constructor does commit us to
maintaining it forever (in v4 at least), which is why I was hesitant earlier.
Based on our discussion here, though, I think there might be some value in
making it look different from wrap() though, given the different semantics.
Also, the fact that {{TraceRunnable}} already has a public constructor tends to
strengthen the argument for giving them both public constructors (but not
adding a TraceScope form... we shouldn't have added that in the first place :P )
> TraceRunnable and TraceCallable should be built using parent spanId not scope
> -----------------------------------------------------------------------------
>
> Key: HTRACE-359
> URL: https://issues.apache.org/jira/browse/HTRACE-359
> Project: HTrace
> Issue Type: Bug
> Components: core
> Affects Versions: 4.0
> Reporter: Mike Drob
> Assignee: Mike Drob
> Attachments: HTRACE-359.patch.txt, HTRACE-359.patch.txt,
> HTRACE-359.v3.patch.txt
>
>
> TraceRunnable/Callable both take a parent TraceScope and extract the span Id
> from it when executing the task. Instead, we should allow users to create
> custom TraceRunnable/Callable instances with only a SpanId instead of a full
> TraceScope, for instance when reading a span id from an RPC call and a
> TraceScope object is not available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
