[
https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434120#comment-15434120
]
Nisala Mendis commented on HTRACE-362:
--------------------------------------
Hi Colin,
I will do the changes to remove opening the table for each span we receive.
Make sure the table is properly closed.
{code}
sbuilder.clear()
.setTraceId(span.getSpanId().getHigh())
.setStart(span.getStartTimeMillis())
.setStop(span.getStopTimeMillis())
.setSpanId(span.getSpanId().getLow())
.setProcessId(span.getTracerId())
.setDescription(span.getDescription());
if (span.getParents().length == 0) {
sbuilder.setParentId(0);
} else if (span.getParents().length > 0) {
sbuilder.setParentId(span.getParents()[0].getLow());
if (span.getParents().length > 1) {
LOG.error("error: HBaseSpanReceiver does not support spans " +
"with multiple parents. Ignoring multiple parents for " +
span);
}
{code}
I followed the approach which is used in HBase receiver. If you notice SpanId
is separated to span id and trace id here. Process is used as tracer id. This
is the same logic I have followed for persisting parents. I have only persisted
parent at 0. column_span_parent column I used for convenience when at Span
viewer, kudu scanner could retrieve root span easily. ( check for root spans )
Please check span viewer classes as well. If you can point to kudu binaries you
can excute unit tests which are currently being disabled. I have wrote test
span receiver as well as span viewer.
Regards
Nisala
> Apache KUDU Span receiver implementation for Apache HTrace
> ----------------------------------------------------------
>
> Key: HTRACE-362
> URL: https://issues.apache.org/jira/browse/HTRACE-362
> Project: HTrace
> Issue Type: Bug
> Reporter: Nisala Mendis
> Assignee: Nisala Mendis
> Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch,
> HTRACE-362.003.patch, HTRACE-362.004.patch, HTRACE-362.005.patch,
> kudu_receiver.patch, kudu_span_receiver_basic_design.pdf
>
>
> Implementation should be carried two components as span receiver that writes
> kudu back end and span viewer to view written span/traces.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
