[
https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404578#comment-15404578
]
Colin P. McCabe commented on HTRACE-362:
----------------------------------------
Thank you for attaching {{HTRACE-362.002.patch}}.
KuduClientConfiguration: like I wrote earlier, why aren't these fields final?
KuduReceiverConstants: it's good that these are final. However, why not make
them package-private instead of public? They will be packaged-private if there
is no modifier (private, public, etc.). Also, like I wrote earlier, you should
not prefix your configuration keys with "htrace."
Like I also commented earlier, you should not be using protobuf here. Instead,
we should be using the types that are built into Kudu. We do not want to store
spans as blobs (i.e. a series of bytes) inside Kudu.
In general, I feel like you didn't address my previous comments. It's
frustrating to see a new patch which doesn't address the problems of the old
one. For example, you still have the Cloudera repos in the pom.xml, even
though I commented that this isn't appropriate for upstream. Perhaps it would
help if you write a comment on JIRA responding to each issue someone brings up.
> Apache KUDU Span receiver implementation for Apache HTrace
> ----------------------------------------------------------
>
> Key: HTRACE-362
> URL: https://issues.apache.org/jira/browse/HTRACE-362
> Project: HTrace
> Issue Type: Bug
> Reporter: Nisala Mendis
> Assignee: Nisala Mendis
> Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch,
> kudu_receiver.patch, kudu_span_receiver_basic_design.pdf
>
>
> Implementation should be carried two components as span receiver that writes
> kudu back end and span viewer to view written span/traces.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
