[jira] [Commented] (HTRACE-393) Binary annotations are being shown as base64 in the zipkin frontend

[Raam (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HTRACE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795805#comment-15795805
 ] 

Raam  commented on HTRACE-393:
------------------------------

Thank you for a wonderful library, I am happy I can help. 

The fix worked for me. After changing this the annotations simply showed.
I hope this is what you mean: 
>From 44ef5de136471ded6e65615218748a13796487e1 Mon Sep 17 00:00:00 2001
From: rrh <r...@findhotel.net>
Date: Tue, 3 Jan 2017 17:22:46 +0100
Subject: [PATCH] Changed binary annotations type from binary to string

---
 .../java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java   | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java
 
b/htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java
index 44baea0..5b23032 100644
--- 
a/htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java
+++ 
b/htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java
@@ -27,6 +27,7 @@ import org.apache.commons.logging.LogFactory;
 import org.apache.htrace.core.TimelineAnnotation;
 
 import java.io.UnsupportedEncodingException;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
@@ -153,13 +154,9 @@ public class HTraceToZipkinConverter {
     List<BinaryAnnotation> l = new ArrayList<BinaryAnnotation>();
     for (Map.Entry<String, String> e : span.getKVAnnotations().entrySet()) {
       BinaryAnnotation binaryAnn = new BinaryAnnotation();
-      binaryAnn.setAnnotation_type(AnnotationType.BYTES);
+      binaryAnn.setAnnotation_type(AnnotationType.STRING);
       binaryAnn.setKey(e.getKey());
-      try {
-        binaryAnn.setValue(e.getValue().getBytes("UTF-8"));
-      } catch (UnsupportedEncodingException ex) {
-        LOG.error("Error encoding string as UTF-8", ex);
-      }
+      binaryAnn.setValue(e.getValue().getBytes(StandardCharsets.UTF_8));
       binaryAnn.setHost(ep);
       l.add(binaryAnn);
     }
-- 
2.10.0



> Binary annotations are being shown as base64 in the zipkin frontend 
> --------------------------------------------------------------------
>
>                 Key: HTRACE-393
>                 URL: https://issues.apache.org/jira/browse/HTRACE-393
>             Project: HTrace
>          Issue Type: Bug
>          Components: zipkin
>    Affects Versions: 4.3
>            Reporter: Raam 
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> As discussed in the mailing list:
>  Seems like HTraceToZipkinConverter.java tags all binary annotations as the 
> BYTES thrift data type although a string is being sent 
> https://github.com/apache/incubator-htrace/blob/master/htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java#L156.
> A string is always sent since this is the signature of 
> TraceScope.addKVAnnotation: public void addKVAnnotation(String key, String 
> value)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)