[
https://issues.apache.org/jira/browse/HTRACE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796180#comment-15796180
]
Hudson commented on HTRACE-393:
-------------------------------
SUCCESS: Integrated in Jenkins build HTrace-Master #276 (See
[https://builds.apache.org/job/HTrace-Master/276/])
HTRACE-393 Changed binary annotations type from binary to string (stack: rev
bf03c0bdf8b2ffc2d393be369b7152047992d299)
* (edit)
htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java
> Binary annotations are being shown as base64 in the zipkin frontend
> --------------------------------------------------------------------
>
> Key: HTRACE-393
> URL: https://issues.apache.org/jira/browse/HTRACE-393
> Project: HTrace
> Issue Type: Bug
> Components: zipkin
> Affects Versions: 4.3
> Reporter: Raam
> Assignee: Raam
> Fix For: 4.3
>
> Attachments:
> 0001-HTRACE-393-Changed-binary-annotations-type-from-bina.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> As discussed in the mailing list:
> Seems like HTraceToZipkinConverter.java tags all binary annotations as the
> BYTES thrift data type although a string is being sent
> https://github.com/apache/incubator-htrace/blob/master/htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java#L156.
> A string is always sent since this is the signature of
> TraceScope.addKVAnnotation: public void addKVAnnotation(String key, String
> value)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
