javeme commented on code in PR #2200:
URL:
https://github.com/apache/incubator-hugegraph/pull/2200#discussion_r1168636750
##########
hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTable.java:
##########
@@ -359,6 +358,7 @@ public long estimateNumKeys(RocksDBSessions.Session
session) {
@Override
public byte[] position(String position) {
+ // TODO: START & END is same & be empty now? remove one?
Review Comment:
yes, but the meanings are different
##########
hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTables.java:
##########
@@ -218,6 +218,7 @@ public IndexTable(String database, String table) {
}
@Override
+ // TODO: why this method is same as super.eliminate() in RocksDBTable,
del it?
Review Comment:
added the assert?
##########
hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:
##########
@@ -440,8 +427,8 @@ private static OpenedRocksDB openRocksDB(HugeConfig config,
return new OpenedRocksDB(rocksdb, cfHandles, sstFileManager);
}
- private static Set<String> mergeOldCFs(String path, List<String> cfNames)
- throws RocksDBException {
+ private static Set<String> mergeOldCFs(String path,
+ List<String> cfNames) throws
RocksDBException {
Review Comment:
prefer the old style
##########
hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:
##########
@@ -299,24 +295,20 @@ public String buildSnapshotPath(String snapshotPrefix) {
// Like: rocksdb-data/*
Path pureDataPath = parentParentPath.relativize(originDataPath);
// Like: parent_path/snapshot_rocksdb-data/*
- Path snapshotPath = parentParentPath.resolve(snapshotPrefix + "_" +
- pureDataPath);
+ Path snapshotPath = parentParentPath.resolve(snapshotPrefix + "_" +
pureDataPath);
E.checkArgument(snapshotPath.toFile().exists(),
- "The snapshot path '%s' doesn't exist",
- snapshotPath);
+ "The snapshot path '%s' doesn't exist", snapshotPath);
Review Comment:
it's more clear to keep 3 lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
