javeme commented on code in PR #2200:
URL:
https://github.com/apache/incubator-hugegraph/pull/2200#discussion_r1320763696
##########
hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBStore.java:
##########
@@ -774,7 +754,7 @@ public void resumeSnapshot(String snapshotPrefix, boolean
deleteSnapshot) {
}
for (Map.Entry<String, RocksDBSessions> entry :
- snapshotPaths.entrySet()) {
+ snapshotPaths.entrySet()) {
Review Comment:
keep in one line?
##########
hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTable.java:
##########
@@ -359,6 +353,7 @@ public long estimateNumKeys(RocksDBSessions.Session
session) {
@Override
public byte[] position(String position) {
+ // TODO: START & END is same & be empty now? remove one?
Review Comment:
the values are equaled, but the meanings are different, we can add NOTE for
the const define
##########
hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:
##########
@@ -440,8 +427,8 @@ private static OpenedRocksDB openRocksDB(HugeConfig config,
return new OpenedRocksDB(rocksdb, cfHandles, sstFileManager);
}
- private static Set<String> mergeOldCFs(String path, List<String> cfNames)
- throws RocksDBException {
+ private static Set<String> mergeOldCFs(String path,
+ List<String> cfNames) throws
RocksDBException {
Review Comment:
OK
##########
hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTables.java:
##########
@@ -218,6 +218,7 @@ public IndexTable(String database, String table) {
}
@Override
+ // TODO: why this method is same as super.eliminate() in RocksDBTable,
del it?
Review Comment:
I checked and find out that **delete() method is override by IndexTable, we
want to call super.delete() instead of this.delete() here**. we can add a NOTE
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
