javeme commented on code in PR #480:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/480#discussion_r1229810027
##########
hugegraph-loader/pom.xml:
##########
@@ -41,12 +41,18 @@
<final.name>apache-${release.name}-incubating-${project.version}</final.name>
<jackson.version>2.12.3</jackson.version>
<hadoop.version>3.3.1</hadoop.version>
+ <gson.version>2.8.5</gson.version>
<assembly.dir>${project.basedir}/assembly</assembly.dir>
<assembly.descriptor.dir>${assembly.dir}/descriptor</assembly.descriptor.dir>
<assembly.static.dir>${assembly.dir}/static</assembly.static.dir>
</properties>
<dependencies>
+ <dependency>
Review Comment:
prefer to move to line 99
##########
hugegraph-loader/pom.xml:
##########
@@ -612,6 +622,55 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>3.4.1</version>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.glassfish.jersey</pattern>
+
<shadedPattern>shaded.org.glassfish.jersey</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>jakarta.ws.rs</pattern>
Review Comment:
please note the
[checkStatus()](https://github.com/apache/incubator-hugegraph-commons/blob/master/hugegraph-common/src/main/java/org/apache/hugegraph/rest/AbstractRestClient.java#L193)
is an abstract method, I'm not sure the shaded class with
`shaded.jakarta.ws.rs` package is still named `jakarta.ws.rs.core.Response`.
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/spark/HugeGraphSparkLoader.java:
##########
@@ -293,8 +293,8 @@ private void parse(Row row, Map.Entry<ElementBuilder,
List<GraphElement>> builde
case HDFS:
FileSource fileSource = struct.input().asFileSource();
String delimiter = fileSource.delimiter();
- elements = builder.build(fileSource.header(),
-
row.mkString(delimiter).split(delimiter));
+
+ elements = builder.build(row);
Review Comment:
not sure why changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
