coderzc commented on code in PR #259:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/259#discussion_r1263334850
##########
computer-k8s-operator/crd-generate/api/v1/groupversion_info.go:
##########
@@ -16,42 +16,18 @@ under the License.
*/
// Package v1 contains API Schema definitions for the computer v1 API group
-//+kubebuilder:object:generate=true
-//+groupName=hugegraph.apache.org
+// +kubebuilder:object:generate=true
+// +groupName=operator.hugegraph.apache.org
package v1
import (
"k8s.io/apimachinery/pkg/runtime/schema"
"sigs.k8s.io/controller-runtime/pkg/scheme"
)
-// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get
-// +kubebuilder:rbac:groups=core,resources=namespaces,verbs=get;create;update
-//
+kubebuilder:rbac:groups=hugegraph.apache.org,resources=hugegraphcomputerjobs,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=hugegraph.apache.org,resources=hugegraphcomputerjobs/status,verbs=get;update;patch
-//
+kubebuilder:rbac:groups=hugegraph.apache.org,resources=hugegraphcomputerjobs/finalizers,verbs=update
-//
+kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=apps,resources=deployments/status,verbs=get
-//
+kubebuilder:rbac:groups=apps,resources=statefulsets,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=apps,resources=statefulsets/status,verbs=get
-// +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch
-// +kubebuilder:rbac:groups=core,resources=pods/status,verbs=get
-// +kubebuilder:rbac:groups=core,resources=pods/log,verbs=get;list;watch
-//
+kubebuilder:rbac:groups=core,resources=services,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=core,resources=services/status,verbs=get
-//
+kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=core,resources=events/status,verbs=get
-//
+kubebuilder:rbac:groups=core,resources=configmaps,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=batch,resources=jobs/status,verbs=get
-//
+kubebuilder:rbac:groups=extensions,resources=ingresses,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=extensions,resources=ingresses/status,verbs=get
-
Review Comment:
Why remove these annotations？
##########
computer-k8s-operator/crd-generate/api/v1/groupversion_info.go:
##########
@@ -16,42 +16,18 @@ under the License.
*/
// Package v1 contains API Schema definitions for the computer v1 API group
-//+kubebuilder:object:generate=true
-//+groupName=hugegraph.apache.org
+// +kubebuilder:object:generate=true
+// +groupName=operator.hugegraph.apache.org
package v1
import (
"k8s.io/apimachinery/pkg/runtime/schema"
"sigs.k8s.io/controller-runtime/pkg/scheme"
)
-// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get
-// +kubebuilder:rbac:groups=core,resources=namespaces,verbs=get;create;update
-//
+kubebuilder:rbac:groups=hugegraph.apache.org,resources=hugegraphcomputerjobs,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=hugegraph.apache.org,resources=hugegraphcomputerjobs/status,verbs=get;update;patch
-//
+kubebuilder:rbac:groups=hugegraph.apache.org,resources=hugegraphcomputerjobs/finalizers,verbs=update
-//
+kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=apps,resources=deployments/status,verbs=get
-//
+kubebuilder:rbac:groups=apps,resources=statefulsets,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=apps,resources=statefulsets/status,verbs=get
-// +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch
-// +kubebuilder:rbac:groups=core,resources=pods/status,verbs=get
-// +kubebuilder:rbac:groups=core,resources=pods/log,verbs=get;list;watch
-//
+kubebuilder:rbac:groups=core,resources=services,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=core,resources=services/status,verbs=get
-//
+kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=core,resources=events/status,verbs=get
-//
+kubebuilder:rbac:groups=core,resources=configmaps,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=batch,resources=jobs/status,verbs=get
-//
+kubebuilder:rbac:groups=extensions,resources=ingresses,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=extensions,resources=ingresses/status,verbs=get
-
Review Comment:
Why remove these annotations？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
