Radeity commented on code in PR #259: URL: https://github.com/apache/incubator-hugegraph-computer/pull/259#discussion_r1268296225
########## computer-k8s-operator/crd-generate/config/default/kustomization.yaml: ########## @@ -25,63 +25,65 @@ namespace: hugegraph-computer-operator-system namePrefix: hugegraph-computer-operator- # Labels to add to all resources and selectors. -#commonLabels: -# someName: someValue +#labels: +#- includeSelectors: true +# pairs: +# someName: someValue -bases: -#- ../crd +resources: +- ../crd - ../rbac - ../etcd - ../manager # [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix including the one in # crd/kustomization.yaml -#- ../webhook +- ../webhook # [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER'. 'WEBHOOK' components are required. -#- ../certmanager +- ../certmanager # [PROMETHEUS] To enable prometheus monitor, uncomment all sections with 'PROMETHEUS'. #- ../prometheus patchesStrategicMerge: # Protect the /metrics endpoint by putting it behind auth. # If you want your controller-manager to expose the /metrics # endpoint w/o any authn/z, please comment the following line. -#- manager_auth_proxy_patch.yaml +- manager_auth_proxy_patch.yaml Review Comment: Sorry for the late reply, in my understanding `kube-rbac-proxy` behaves like a proxy of kubernete api server, and it will check the authentication information before sending request to api-server. > Does the operator need through it to access the k8s-API? Originally, operator pod has already configured `serviceAccountName` with which means it's authorized. Thus, `kube-rbac-proxy` has no effect to operator (authentication will pass). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
