aroundabout commented on code in PR #2241:
URL:
https://github.com/apache/incubator-hugegraph/pull/2241#discussion_r1273195174
##########
hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -79,13 +79,20 @@ if [ ! -d "$LOGS" ]; then
mkdir -p "$LOGS"
fi
+GERMLIN_SERVER_YAML="gremlin-server.yaml"
+
+if [ $PRELOAD ]; then
Review Comment:
> Some tiny suggestion, better use double square brackets to avoid exception
if user don't set `PRELOAD`, also, we can add condition check whether the value
is true. Like: `if [[ $PRELOAD = "true" ]]; then`.
thx for your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
