javeme commented on code in PR #2241:
URL:
https://github.com/apache/incubator-hugegraph/pull/2241#discussion_r1275955189
##########
hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -79,6 +80,12 @@ if [ ! -d "$LOGS" ]; then
mkdir -p "$LOGS"
fi
+if [[ $PRELOAD == "true" ]]; then
+ sed -i -e 's/empty-sample.groovy/example.groovy/g'
"${CONF}"/gremlin-server.yaml
+ sed -i -e '/registerRocksDB/d; /serverStarted/d'
"${SCRIPTS}"/example.groovy
Review Comment:
prefer to make a copy, then modify the copied file
##########
hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -79,6 +80,12 @@ if [ ! -d "$LOGS" ]; then
mkdir -p "$LOGS"
fi
+if [[ $PRELOAD == "true" ]]; then
+ sed -i -e 's/empty-sample.groovy/example.groovy/g'
"${CONF}"/gremlin-server.yaml
+ sed -i -e '/registerRocksDB/d; /serverStarted/d'
"${SCRIPTS}"/example.groovy
+fi
+
+
Review Comment:
expect just one blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
