VGalaxies commented on code in PR #2275:
URL:
https://github.com/apache/incubator-hugegraph/pull/2275#discussion_r1288011157
##########
hugegraph-store/hg-store-core/pom.xml:
##########
@@ -121,9 +121,48 @@
<version>${revision}</version>
<scope>system</scope>
<systemPath>
-
${project.basedir}/../hg-store-dist/src/assembly/ext-lib/hugegraph-core-1.5.0.jar
+
${top.level.dir}/hg-store-dist/src/assembly/ext-lib/hugegraph-core-1.5.0.jar
</systemPath>
</dependency>
+ <!-- tinkerpop -->
+ <dependency>
Review Comment:
> why we need add tinkerpop dependency here?
>
> @VGalaxies any context?
As stated by @heiyan-2020, assuming there are projects A (`hg-store-core`)
and B (`hugegraph-core`), where project A depends on project B, and project B
is a system dependency, the dependencies within project B will not be
automatically inherited by project A.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
