imbajin commented on code in PR #2275:
URL:
https://github.com/apache/incubator-hugegraph/pull/2275#discussion_r1291180343
##########
hugegraph-store/hg-store-core/pom.xml:
##########
@@ -121,9 +121,48 @@
<version>${revision}</version>
<scope>system</scope>
<systemPath>
-
${project.basedir}/../hg-store-dist/src/assembly/ext-lib/hugegraph-core-1.5.0.jar
+
${top.level.dir}/hg-store-dist/src/assembly/ext-lib/hugegraph-core-1.5.0.jar
</systemPath>
</dependency>
+ <!-- tinkerpop -->
+ <dependency>
Review Comment:
> As mentioned in the last item of "Main change", tinkerpop is depended on
by `hg-store-core`, and in internal version the dependency is passed on through
`hugegraph-core` which imported as usal maven dependency. But the current
temporary solution is that importing `hugegraph-core` jar package through
system dependency. In this way, the dependencies in `hugegraph-core` cannot be
passed on, so the dependencies need to be added again in `hg-store-core`
@heiyan-2020 get it, but we need add `comment/TODO` mark here? (maybe in
next PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
