imbajin commented on code in PR #510:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/510#discussion_r1299299375
##########
hugegraph-loader/assembly/static/bin/hugegraph-loader.sh:
##########
@@ -78,4 +81,4 @@ export JVM_OPTS="$JVM_OPTS -Xmx10g -cp $LOADER_CLASSPATH"
exec ${JAVA} -Dname="HugeGraphLoader" -Dloader.home.path=${TOP}
-Dlog4j.configurationFile=${CONF}/log4j2.xml \
-Djava.library.path=${NATIVE} \
-${JVM_OPTS} org.apache.hugegraph.loader.HugeGraphLoader ${VARS}
+${JVM_OPTS} org.apache.hugegraph.loader.HugeGraphLoader ${VARS}
Review Comment:
lack empty line （in the end）
##########
hugegraph-loader/assembly/static/bin/hugegraph-loader.sh:
##########
@@ -78,4 +81,4 @@ export JVM_OPTS="$JVM_OPTS -Xmx10g -cp $LOADER_CLASSPATH"
exec ${JAVA} -Dname="HugeGraphLoader" -Dloader.home.path=${TOP}
-Dlog4j.configurationFile=${CONF}/log4j2.xml \
-Djava.library.path=${NATIVE} \
-${JVM_OPTS} org.apache.hugegraph.loader.HugeGraphLoader ${VARS}
+${JVM_OPTS} org.apache.hugegraph.loader.HugeGraphLoader ${VARS}
Review Comment:
lack empty line （in the end）
##########
hugegraph-loader/assembly/static/bin/hugegraph-loader.sh:
##########
@@ -16,11 +16,11 @@
# under the License.
#
abs_path() {
- SOURCE="${BASH_SOURCE[0]}"
- while [[ -h "$SOURCE" ]]; do
+ SOURCE="$0"
+ while [ -h "$SOURCE" ]; do
DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
SOURCE="$(readlink "$SOURCE")"
- [[ ${SOURCE} != /* ]] && SOURCE="$DIR/$SOURCE"
+ [ "${SOURCE}" != /* ] && SOURCE="$DIR/$SOURCE"
Review Comment:
why we use the old style？
show some example thx~
##########
hugegraph-loader/assembly/static/bin/hugegraph-loader.sh:
##########
@@ -16,11 +16,11 @@
# under the License.
#
abs_path() {
- SOURCE="${BASH_SOURCE[0]}"
- while [[ -h "$SOURCE" ]]; do
+ SOURCE="$0"
+ while [ -h "$SOURCE" ]; do
DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
SOURCE="$(readlink "$SOURCE")"
- [[ ${SOURCE} != /* ]] && SOURCE="$DIR/$SOURCE"
+ [ "${SOURCE}" != /* ] && SOURCE="$DIR/$SOURCE"
Review Comment:
why we use the old style？
show some example thx~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
