lzyxx77 commented on code in PR #510:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/510#discussion_r1299308762


##########
hugegraph-loader/assembly/static/bin/hugegraph-loader.sh:
##########
@@ -16,11 +16,11 @@
 # under the License.
 #
 abs_path() {
-    SOURCE="${BASH_SOURCE[0]}"
-    while [[ -h "$SOURCE" ]]; do
+    SOURCE="$0"
+    while [ -h "$SOURCE" ]; do
         DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
         SOURCE="$(readlink "$SOURCE")"
-        [[ ${SOURCE} != /* ]] && SOURCE="$DIR/$SOURCE"
+        [ "${SOURCE}" != /* ] && SOURCE="$DIR/$SOURCE"

Review Comment:
   Because my Ubuntu system's 'sh' command is not linked to 'bash', using the 
'sh' command directly doesn't work. I believe others might encounter the same 
issue, so I've used the old style. If this problem isn't significant, I will 
close this pull request~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to