zhenyuT commented on code in PR #508:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/508#discussion_r1306701074
##########
hugegraph-client/src/main/java/org/apache/hugegraph/api/graph/GraphAPI.java:
##########
@@ -76,10 +73,11 @@ public static String formatProperties(Map<String, Object>
properties) {
* which will invalidate the jersey's automatic decoding
* because it considers the space to be encoded as `%2F`
*/
- return encode(json);
+// return encode(json);
+ return json;
}
- public static String encode(String raw) {
- return UriComponent.encode(raw, Type.QUERY_PARAM_SPACE_ENCODED);
- }
+// public static String encode(String raw) {
+// return UriComponent.encode(raw, Type.QUERY_PARAM_SPACE_ENCODED);
Review Comment:
> any alternative plan?
看原来代码的意图，是要对url中的参数进行编码。但是okhttp中使用HttpUrl.Builder构建url，其实会自动进行编码的，所以感觉没必要由使用方对参数编码后再传参
##########
hugegraph-client/src/main/java/org/apache/hugegraph/api/graph/GraphAPI.java:
##########
@@ -76,10 +73,11 @@ public static String formatProperties(Map<String, Object>
properties) {
* which will invalidate the jersey's automatic decoding
* because it considers the space to be encoded as `%2F`
*/
- return encode(json);
+// return encode(json);
+ return json;
}
- public static String encode(String raw) {
- return UriComponent.encode(raw, Type.QUERY_PARAM_SPACE_ENCODED);
- }
+// public static String encode(String raw) {
+// return UriComponent.encode(raw, Type.QUERY_PARAM_SPACE_ENCODED);
Review Comment:
> any alternative plan?
看原来代码的意图，是要对url中的参数进行编码。但是okhttp中使用HttpUrl.Builder构建url，其实会自动进行编码的，所以感觉没必要由使用方对参数编码后再传参
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
