z7658329 commented on code in PR #508:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/508#discussion_r1309937223


##########
hugegraph-client/pom.xml:
##########
@@ -37,28 +37,73 @@
     </description>
 
     <properties>
+        <lombok.version>1.18.8</lombok.version>
+        <okhttp.version>4.10.0</okhttp.version>

Review Comment:
   shoule extract dependency version  to  root pom.xml, sub module just import?



##########
hugegraph-client/pom.xml:
##########
@@ -37,28 +37,73 @@
     </description>
 
     <properties>
+        <lombok.version>1.18.8</lombok.version>
+        <okhttp.version>4.10.0</okhttp.version>

Review Comment:
   shoule extract dependency version  to  root pom.xml, sub module just import?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to