msgui commented on code in PR #2308:
URL:
https://github.com/apache/incubator-hugegraph/pull/2308#discussion_r1320756220
##########
.github/workflows/check-dependencies.yml:
##########
@@ -3,7 +3,6 @@ name: "3rd-party"
on:
push:
branches:
- - master
Review Comment:
> I'm not sure why need to remove it, since it is a triggering branch
When pushing to the master base-ref/head-ref are not automatically assigned,
leading to frequent errors during such pushes. The reason for removing them is
that during PRs, we can directly check for the introduction of unauthorized
3rd-party libraries (exceptional libraries) through 'Dependency Review' and
make the decision on whether to introduce them. There is no need to showcase
this during master branch pushes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
