msgui commented on code in PR #2308:
URL:
https://github.com/apache/incubator-hugegraph/pull/2308#discussion_r1320756220
##########
.github/workflows/check-dependencies.yml:
##########
@@ -3,7 +3,6 @@ name: "3rd-party"
on:
push:
branches:
- - master
Review Comment:
> I'm not sure why need to remove it, since it is a triggering branch
When pushing to the master branch, base-ref/head-ref isn't auto-assigned,
leading to frequent errors.
The reason for their removal is that during PRs, we can directly check for
unauthorized 3rd-party libraries (exceptional libraries) through 'Dependency
Review' and decide whether to introduce them.
There's no need to showcase this during master branch pushes.
[Doc link
👇](https://github.com/actions/dependency-review-action#:~:text=base%2Dref/,none)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
