imbajin commented on code in PR #265:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/265#discussion_r1326733499
##########
computer-api/src/main/java/org/apache/hugegraph/computer/core/config/ComputerOptions.java:
##########
@@ -645,6 +645,22 @@ public static synchronized ComputerOptions instance() {
"hugegraph"
);
+ public static final ConfigOption<String> HUGEGRAPH_USERNAME =
+ new ConfigOption<>(
+ "hugegraph.username",
+ "The graph username and password used for authentication.",
+ null,
+ ""
+ );
+
+ public static final ConfigOption<String> HUGEGRAPH_PASSWORD =
+ new ConfigOption<>(
+ "hugegraph.password",
+ "The graph username and password used for authentication.",
+ null,
+ ""
+ );
+
Review Comment:
Some old refer: (Note: the `description/variable name` **could be
improved**, no need to **copy it**)
```java
public static final ConfigOption<String> AUTH_TOKEN =
new ConfigOption<>(
"hugegraph.token",
"The auth value for compute job to certificate," +
" should only used for HugeGraph server now",
""
);
public static final ConfigOption<String> AUTH_USRNAME =
new ConfigOption<>(
"hugegraph.usrname",
"The usrname for compute job to certificate with " +
"basic auth, should only used in test environment, " +
"consider ban it in future.",
""
);
public static final ConfigOption<String> AUTH_PASSWD =
new ConfigOption<>(
"hugegraph.passwd",
"The password for compute job to certificate with " +
"basic auth, should only used in test environment, " +
"consider ban it in future.",
""
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
