diaohancai commented on code in PR #265:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/265#discussion_r1327919253
##########
computer-api/src/main/java/org/apache/hugegraph/computer/core/output/hg/task/TaskManager.java:
##########
@@ -56,7 +56,9 @@ public TaskManager(Config config) {
this.config = config;
String url = config.get(ComputerOptions.HUGEGRAPH_URL);
String graph = config.get(ComputerOptions.HUGEGRAPH_GRAPH_NAME);
- this.client = new HugeClientBuilder(url, graph).build();
+ String username = config.get(ComputerOptions.HUGEGRAPH_USERNAME);
+ String password = config.get(ComputerOptions.HUGEGRAPH_PASSWORD);
+ this.client = new HugeClientBuilder(url, graph).configUser(username,
password).build();
Review Comment:
Hi~ I reviewed the code. Now I'm confused about two things.
1. HugeClientBuilder api not found
`HugeClientBuilder.configToken(token)`
I did not found this api, should I upgrade the version of 'hugegraph-client'
dependency?
2. Auth mode choose
[hugegraph user's guide
config-authentication](https://hugegraph.apache.org/cn/docs/config/config-authentication/)
As hugegraph user's guide said, there are two auth mode:
- ConfigAuthenticator mode: configure user and token in
rest-server.properties statically.
- StandardAuthenticator mode: configure user and password in DB dynamically.
And the ConfigAuthenticator mode seems not to be recommended, is it same as
`HugeClientBuilder.configToken(token)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
