VGalaxies commented on code in PR #2319:
URL:
https://github.com/apache/incubator-hugegraph/pull/2319#discussion_r1359866234
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/TaskManager.java:
##########
@@ -87,11 +108,36 @@ private TaskManager(int pool) {
public void addScheduler(HugeGraphParams graph) {
E.checkArgumentNotNull(graph, "The graph can't be null");
-
- TaskScheduler scheduler = new StandardTaskScheduler(graph,
- this.taskExecutor, this.taskDbExecutor,
- this.serverInfoDbExecutor);
- this.schedulers.put(graph, scheduler);
+ LOG.info("Use {} as the scheduler of graph ({})",
+ graph.schedulerType(), graph.name());
Review Comment:
@zyxxoo 意思是将 `task.scheduler_type` 这个选项从 `CoreOptions` 移动到 `ServerOptions`
中吗？我理解的是每个图实例都可以单独设定调度类型
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/TaskManager.java:
##########
@@ -87,11 +108,36 @@ private TaskManager(int pool) {
public void addScheduler(HugeGraphParams graph) {
E.checkArgumentNotNull(graph, "The graph can't be null");
-
- TaskScheduler scheduler = new StandardTaskScheduler(graph,
- this.taskExecutor, this.taskDbExecutor,
- this.serverInfoDbExecutor);
- this.schedulers.put(graph, scheduler);
+ LOG.info("Use {} as the scheduler of graph ({})",
+ graph.schedulerType(), graph.name());
Review Comment:
@zyxxoo 意思是将 `task.scheduler_type` 这个选项从 `CoreOptions` 移动到 `ServerOptions`
中吗？我理解的是每个图实例都可以单独设定调度类型
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
