VGalaxies commented on code in PR #2319:
URL:
https://github.com/apache/incubator-hugegraph/pull/2319#discussion_r1359869892
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/TaskManager.java:
##########
@@ -156,6 +206,21 @@ private void closeSchedulerTx(HugeGraphParams graph) {
}
}
+ private void closeDistributedSchedulerTx(HugeGraphParams graph) {
+ final Callable<Void> closeTx = () -> {
+ // Do close-tx for current thread
+ graph.closeTx();
+ // Let other threads run
+ Thread.yield();
Review Comment:
> 这里为啥会有这段代码哈? 为什么要让其他线程run呢
参考的是 close `schedulerExecutor` 的逻辑
`org.apache.hugegraph.task.TaskManager#closeSchedulerTx`
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/TaskManager.java:
##########
@@ -156,6 +206,21 @@ private void closeSchedulerTx(HugeGraphParams graph) {
}
}
+ private void closeDistributedSchedulerTx(HugeGraphParams graph) {
+ final Callable<Void> closeTx = () -> {
+ // Do close-tx for current thread
+ graph.closeTx();
+ // Let other threads run
+ Thread.yield();
Review Comment:
> 这里为啥会有这段代码哈? 为什么要让其他线程run呢
参考的是 close `schedulerExecutor` 的逻辑
`org.apache.hugegraph.task.TaskManager#closeSchedulerTx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
