imbajin commented on code in PR #309: URL: https://github.com/apache/incubator-hugegraph-doc/pull/309#discussion_r1434235435
########## content/cn/docs/contribution-guidelines/validate-release.md: ########## @@ -154,26 +151,42 @@ bin/start-computer.sh -d local -r master ## 邮件模板 检查完成后, 你应该按不同角色回复邮件: (普通开发者 & PMC 成员) +```markdown +[] +1 同意 +[] +0 没有意见 + +[] -1 不同意，并注明原因 +``` ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 Review Comment: ```suggestion 4.Build successfully on XX OS version XXX ``` ########## content/cn/docs/contribution-guidelines/validate-release.md: ########## @@ -154,26 +151,42 @@ bin/start-computer.sh -d local -r master ## 邮件模板 检查完成后, 你应该按不同角色回复邮件: (普通开发者 & PMC 成员) +```markdown +[] +1 同意 +[] +0 没有意见 + +[] -1 不同意，并注明原因 Review Comment: ```suggestion [] +1 approve [] +0 no opinion [] -1 disapprove with the reason ``` ########## content/cn/docs/contribution-guidelines/validate-release.md: ########## @@ -154,26 +151,42 @@ bin/start-computer.sh -d local -r master ## 邮件模板 检查完成后, 你应该按不同角色回复邮件: (普通开发者 & PMC 成员) +```markdown +[] +1 同意 +[] +0 没有意见 + +[] -1 不同意，并注明原因 +``` ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK Review Comment: ```suggestion 9. Test running xxx service OK ``` ########## content/en/docs/contribution-guidelines/validate-release.md: ########## @@ -153,24 +153,43 @@ more reference official website: https://hugegraph.apache.org/cn/docs/quickstart ## Mail Template After the check & test, you should reply the mail with the following content: (normal devs & PMC) + +```markdown +[] +1 approve + +[] +0 no opinion + +[] -1 disapprove with the reason +``` + ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK Review Comment: ```suggestion 9. Test running XXX service OK ``` ########## content/en/docs/contribution-guidelines/validate-release.md: ########## @@ -153,24 +153,43 @@ more reference official website: https://hugegraph.apache.org/cn/docs/quickstart ## Mail Template After the check & test, you should reply the mail with the following content: (normal devs & PMC) + +```markdown +[] +1 approve + +[] +0 no opinion + +[] -1 disapprove with the reason +``` + ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK +10. .... ``` and the PMC members should reply with `binding`, it's important for summary the valid votes: ```markdown +1 (binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 Review Comment: ```suggestion 4.Build successfully on XX OS & Version XX ``` ########## content/en/docs/contribution-guidelines/validate-release.md: ########## @@ -153,24 +153,43 @@ more reference official website: https://hugegraph.apache.org/cn/docs/quickstart ## Mail Template After the check & test, you should reply the mail with the following content: (normal devs & PMC) + +```markdown +[] +1 approve + +[] +0 no opinion + +[] -1 disapprove with the reason +``` + ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK +10. .... ``` and the PMC members should reply with `binding`, it's important for summary the valid votes: ```markdown +1 (binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK Review Comment: ```suggestion 9. Test running XX process OK ``` ########## content/en/docs/contribution-guidelines/validate-release.md: ########## @@ -153,24 +153,43 @@ more reference official website: https://hugegraph.apache.org/cn/docs/quickstart ## Mail Template After the check & test, you should reply the mail with the following content: (normal devs & PMC) + +```markdown +[] +1 approve + +[] +0 no opinion + +[] -1 disapprove with the reason +``` + ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 Review Comment: ```suggestion 7.Compile from source is fine under JavaXX ``` ########## content/cn/docs/contribution-guidelines/validate-release.md: ########## @@ -154,26 +151,42 @@ bin/start-computer.sh -d local -r master ## 邮件模板 检查完成后, 你应该按不同角色回复邮件: (普通开发者 & PMC 成员) +```markdown +[] +1 同意 +[] +0 没有意见 + +[] -1 不同意，并注明原因 +``` ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 Review Comment: ```suggestion 7.Compile from source is fine under JavaX ``` ########## content/cn/docs/contribution-guidelines/validate-release.md: ########## @@ -154,26 +151,42 @@ bin/start-computer.sh -d local -r master ## 邮件模板 检查完成后, 你应该按不同角色回复邮件: (普通开发者 & PMC 成员) +```markdown +[] +1 同意 +[] +0 没有意见 + +[] -1 不同意，并注明原因 +``` ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK +10. .... ``` 特别注意 PMC 成员必须使用 `binding` 标记回复邮件, 这对于统计有效投票很重要; ```markdown +1 (binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 Review Comment: ```suggestion 4.Build successfully on XX OS Version XX ``` ########## content/cn/docs/contribution-guidelines/validate-release.md: ########## @@ -154,26 +151,42 @@ bin/start-computer.sh -d local -r master ## 邮件模板 检查完成后, 你应该按不同角色回复邮件: (普通开发者 & PMC 成员) +```markdown +[] +1 同意 +[] +0 没有意见 + +[] -1 不同意，并注明原因 +``` ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK +10. .... ``` 特别注意 PMC 成员必须使用 `binding` 标记回复邮件, 这对于统计有效投票很重要; ```markdown +1 (binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK Review Comment: ```suggestion 9. Test running XXX service OK ``` ########## content/en/docs/contribution-guidelines/validate-release.md: ########## @@ -153,24 +153,43 @@ more reference official website: https://hugegraph.apache.org/cn/docs/quickstart ## Mail Template After the check & test, you should reply the mail with the following content: (normal devs & PMC) + +```markdown +[] +1 approve + +[] +0 no opinion + +[] -1 disapprove with the reason +``` + ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 Review Comment: ```suggestion 4.Build successfully on XX OS & Version XX ``` ########## content/en/docs/contribution-guidelines/validate-release.md: ########## @@ -67,7 +69,8 @@ gpg: key 28DCAED849C4180E: public key "coderzc (CODE SIGNING KEY) <zhaocong@apac gpg: Total number processed: 3 gpg: imported: 3 -# 2. Trust release users (trust n username mentioned in voting mail, if more than one user, just repeat the steps in turn or use the script below) +# 2. Trust release users (trust n username mentioned in voting mail, if more than one user, +# just repeat the steps in turn or use the script below) Review Comment: ```suggestion # 2. Trust release users (trust n username mentioned in voting mail, if more than one user, # just repeat the steps in turn or use the script below) ``` ########## content/en/docs/contribution-guidelines/validate-release.md: ########## @@ -153,24 +153,43 @@ more reference official website: https://hugegraph.apache.org/cn/docs/quickstart ## Mail Template After the check & test, you should reply the mail with the following content: (normal devs & PMC) + +```markdown +[] +1 approve + +[] +0 no opinion + +[] -1 disapprove with the reason +``` + ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK +10. .... ``` and the PMC members should reply with `binding`, it's important for summary the valid votes: ```markdown +1 (binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 Review Comment: ```suggestion 7.Compile from source is fine under JavaXX ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
