imbajin commented on code in PR #309: URL: https://github.com/apache/incubator-hugegraph-doc/pull/309#discussion_r1434240002
########## content/cn/docs/contribution-guidelines/validate-release.md: ########## @@ -154,26 +151,42 @@ bin/start-computer.sh -d local -r master ## 邮件模板 检查完成后, 你应该按不同角色回复邮件: (普通开发者 & PMC 成员) +```markdown +[] +1 同意 +[] +0 没有意见 + +[] -1 不同意，并注明原因 +``` ```markdown +1 (non-binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 +8.No empty file & directory found +9.Running server/loader/hubble process OK +10. .... ``` 特别注意 PMC 成员必须使用 `binding` 标记回复邮件, 这对于统计有效投票很重要; ```markdown +1 (binding) I checked: -1. All download links are valid -2. Checksum and signature are OK -3. LICENSE and NOTICE are exist -4. Build successfully on macOS(Big Sur) -5. .... +1.Download link/tag in mail are valid +2.Checksum and GPG signatures are OK +3.LICENSE & NOTICE & DISCLAIMER are exist +4.Build successfully on Ubuntu22.04 & MacOS 14.2 +5.No unexpected binary files +6.Date is right in the NOTICE file +7.Compile from source is fine under Java11 Review Comment: ```suggestion 7.Compile from source is fine under JavaXX ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
