imbajin commented on code in PR #644:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/644#discussion_r1858030473


##########
hugegraph-client/src/main/java/org/apache/hugegraph/structure/traverser/Kneighbor.java:
##########
@@ -37,7 +37,7 @@ public class Kneighbor {
     @JsonProperty
     private Set<Vertex> vertices;
     @JsonProperty
-    private Set<Edge> edges;
+    private Set<?> edges;

Review Comment:
   Although using `<?>` may take effect(no add/update operation here), it is 
still strange why the restriction of generics has been modified to arbitrary 
here. 
   
   It is possible that the **server-side** changes did not meet expectations? 
   
   Wanna to know in what case do I need to pass in a non-Edge Edge?(Is it 
because the definition of server-side generics is too broad?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to