LiJie20190102 commented on code in PR #644:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/644#discussion_r1860192546
##########
hugegraph-client/src/main/java/org/apache/hugegraph/structure/traverser/Kneighbor.java:
##########
@@ -37,7 +37,7 @@ public class Kneighbor {
@JsonProperty
private Set<Vertex> vertices;
@JsonProperty
- private Set<Edge> edges;
+ private Set<?> edges;
Review Comment:
> > ow about this：If 'with_idge' is' false ', we will not return any
information about the edge; If 'with-vertex' is' false 'and does not return
vertex information, the' kneigbor 'parameter has already returned a set of
vertex IDs
>
> Looks okay, but what effect does the **iterator returned** earlier? Do you
have to test what the potential effect is there? See if the test can pass
rightly
if with_edge is false:
`{
"kneighbor": [
"2:car1!2",
"2:car2!4"
],
"size": 2,
"paths": [
{
"objects": [
"1:zhangsan",
"2:car1!2"
]
},
{
"objects": [
"1:zhangsan",
"2:car2!4"
]
}
],
"vertices": [
{
"id": "2:car2!4",
"label": "car",
"type": "vertex",
"properties": {
"age": 4,
"qsdi_task_id": "car2_task_id_test",
"qsdi_record_id": "test_record_id",
"name": "car2",
"qsdi_data_source": "1"
}
},
{
"id": "1:zhangsan",
"label": "people",
"type": "vertex",
"properties": {
"age": 55,
"qsdi_record_id": "926133154860048384",
"name": "zhangsan",
"qsdi_data_source": "1"
}
},
{
"id": "2:car1!2",
"label": "car",
"type": "vertex",
"properties": {
"age": 2,
"qsdi_task_id": "car1_task_id_test",
"qsdi_record_id": "car1_log_id_test",
"name": "car1",
"qsdi_data_source": "1"
}
}
],
"edges": [
"S1:zhangsan>3>3>>S2:car2!4",
"S1:zhangsan>3>3>>S2:car1!2"
]
}`
if with_edge is true:
`{
"kneighbor": [
"2:car1!2",
"2:car2!4"
],
"size": 2,
"paths": [
{
"objects": [
"1:zhangsan",
"2:car1!2"
]
},
{
"objects": [
"1:zhangsan",
"2:car2!4"
]
}
],
"vertices": [
{
"id": "2:car2!4",
"label": "car",
"type": "vertex",
"properties": {
"age": 4,
"qsdi_task_id": "car2_task_id_test",
"qsdi_record_id": "test_record_id",
"name": "car2",
"qsdi_data_source": "1"
}
},
{
"id": "1:zhangsan",
"label": "people",
"type": "vertex",
"properties": {
"age": 55,
"qsdi_record_id": "926133154860048384",
"name": "zhangsan",
"qsdi_data_source": "1"
}
},
{
"id": "2:car1!2",
"label": "car",
"type": "vertex",
"properties": {
"age": 2,
"qsdi_task_id": "car1_task_id_test",
"qsdi_record_id": "car1_log_id_test",
"name": "car1",
"qsdi_data_source": "1"
}
}
],
"edges": [
{
"id": "S1:zhangsan>3>3>>S2:car2!4",
"label": "driver_single",
"type": "edge",
"outV": "1:zhangsan",
"outVLabel": "people",
"inV": "2:car2!4",
"inVLabel": "car",
"properties": {
"qsdi_task_id": "zhangsan_car2_rask_id_test",
"qsdi_record_id": "926133802515111937",
"name": "ride12",
"driver_count": 23,
"qsdi_data_source": "1"
}
},
{
"id": "S1:zhangsan>3>3>>S2:car1!2",
"label": "driver_single",
"type": "edge",
"outV": "1:zhangsan",
"outVLabel": "people",
"inV": "2:car1!2",
"inVLabel": "car",
"properties": {
"qsdi_record_id": "926133804008284160",
"name": "ride88",
"driver_count": 88,
"qsdi_data_source": "1"
}
}
]
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
