imbajin commented on PR #648: URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/648#issuecomment-2572438941
> @imbajin > > > Thanks a lot for your contribution, could refer the doc to format the code: (to avoid a lot of unexpected changes) > > Thank you for the reminder. After I checked my code style, I'm pretty sure I have already opened that configuration. I think there might be a bug: When I pasted the `.editorconfig` from the "apache/incubator-hugegraph" repository, it worked as expected, just like the original file. However, the `.editorconfig` from the "apache/incubator-hugegraph-toolchain" repository didn't work. Maybe we should migrate the `.editorconfig` from "apache/incubator-hugegraph" to "apache/incubator-hugegraph-toolchain" to solve this problem. > > Also, I noticed that: > > ``` > # Ignore the IDEA unsupported warning & it works well (indeed) > continuation_indent_size = 16 > ``` > > It doesn't work on my IDEA version: "IntelliJ IDEA 2024.3.1 (Ultimate Edition)". After referring to this article > > > [youtrack.jetbrains.com/issue/IJPL-148288/Continuation-indent-size-from-IDE-setting-is-not-used-when-using-.editorconfig](https://youtrack.jetbrains.com/issue/IJPL-148288/Continuation-indent-size-from-IDE-setting-is-not-used-when-using-.editorconfig) > > @thorsten.schoening: > > Thanks for reporting this issue. It seems we should use the continuations setting from the IDE's code style setting for your case. > > As a workaround, you could add ij_continuation_indent_size = 8 in .editorconfig. to fix this issue. > > I changed "continuation_indent_size" to "ij_continuation_indent_size", and it worked well,maybe i should ask another issue Thanks for the feedback, we also had separate configuration options for `IDEA` before, which were merged later @returnToInnocence any context for it? (Or shall we add both of them?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
