MuLeiSY2021 commented on code in PR #648:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/648#discussion_r1905230492
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/util/DataTypeUtil.java:
##########
@@ -124,8 +122,7 @@ public static UUID parseUUID(String key, Object rawValue) {
rawValue.getClass()));
}
- private static Object parseSingleValue(String key, Object rawValue,
Review Comment:
Sure, we can use source.type() to fix this problem. Using the strategy
pattern or interfaces might make the code more complex, and since this function
is not complex enough, it's unnecessary to apply them here. The switch
statement is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
