imbajin commented on code in PR #683:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/683#discussion_r2422436904
##########
hugegraph-loader/pom.xml:
##########
@@ -542,6 +542,11 @@
<version>${kafka.testcontainer.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.parboiled</groupId>
+ <artifactId>parboiled-core</artifactId>
+ <version>1.1.8</version> <!-- 稳定版本，与 Gremlin 3.4.x 等组件兼容 -->
Review Comment:
**Dependency Version**: Adding a hard-coded dependency version with a
Chinese comment is not best practice.
**Issues**:
1. Chinese comment should be in English
2. Version should be defined in the properties section for easier maintenance
3. Comment in POM is redundant - version management should be centralized
**Recommendation**:
```xml
<dependency>
<groupId>org.parboiled</groupId>
<artifactId>parboiled-core</artifactId>
<version>${parboiled.version}</version>
</dependency>
```
And add to properties:
```xml
<parboiled.version>1.1.8</parboiled.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
