imbajin commented on code in PR #683:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/683#discussion_r2422428269
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/HugeGraphLoader.java:
##########
@@ -59,14 +88,34 @@ public final class HugeGraphLoader {
private final LoadContext context;
Review Comment:
**Error Handling Issue**: The main() method's error handling has been
changed to swallow exceptions silently by returning instead of rethrowing. This
makes debugging and error tracking difficult in production.
**Recommendation**: Either restore the original exception throwing behavior
or implement proper error logging and exit codes:
```java
public static void main(String[] args) {
HugeGraphLoader loader;
try {
loader = new HugeGraphLoader(args);
} catch (Throwable e) {
Printer.printError("Failed to start loading", e);
System.exit(1); // Exit with error code
}
try {
loader.load();
} catch (Throwable e) {
System.exit(1);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
