Copilot commented on code in PR #687:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/687#discussion_r2480147673
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/KafkaLoadTest.java:
##########
@@ -197,7 +201,7 @@ public void testKafkaCsvFormat() {
"--test-mode", "true"
};
- HugeGraphLoader.main(args);
+ authmain(args);
Review Comment:
Inconsistent indentation: this line uses spaces instead of the standard
single tab indentation used elsewhere in the file.
```suggestion
authmain(args);
```
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/HDFSLoadTest.java:
##########
@@ -133,16 +142,19 @@ public void testHDFSWithInvalidCoreSitePath() {
"peter,35,Shanghai",
"\"li,nary\",26,\"Wu,han\"");
- String[] args = new String[]{
+ List<String> argsList = new ArrayList<>(Arrays.asList(
"-f",
structPath("hdfs_with_invalid_core_site_path/struct.json"),
"-s",
configPath("hdfs_with_invalid_core_site_path/schema.groovy"),
"-g", GRAPH,
"-h", SERVER,
"--batch-insert-threads", "2",
"--test-mode", "true"
- };
+ ));
+ argsList.addAll(Arrays.asList("--username", "admin", "--password",
"pa"));
+
+
Review Comment:
Extra blank line added unnecessarily. This creates inconsistent spacing
compared to similar code blocks at lines 71-73, 100-102, and 126-128.
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/HDFSLoadTest.java:
##########
@@ -109,16 +115,19 @@ public void testHDFSWithCoreSitePathEmpty() {
"peter,35,Shanghai",
"\"li,nary\",26,\"Wu,han\"");
- String[] args = new String[]{
+ List<String> argsList = new ArrayList<>(Arrays.asList(
"-f", structPath("hdfs_with_empty_core_site_path/struct.json"),
"-s",
configPath("hdfs_with_empty_core_site_path/schema.groovy"),
"-g", GRAPH,
"-h", SERVER,
"--batch-insert-threads", "2",
"--test-mode", "true"
- };
+ ));
+ argsList.addAll(Arrays.asList("--username", "admin", "--password",
"pa"));
+
+
Review Comment:
Extra blank line added unnecessarily. This creates inconsistent spacing
compared to similar code blocks at lines 71-73, 100-102, and 153-155.
```suggestion
```
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/HDFSLoadTest.java:
##########
@@ -160,16 +172,19 @@ public void testHDFSWithUnexistCoreSitePath() {
"peter,35,Shanghai",
"\"li,nary\",26,\"Wu,han\"");
- String[] args = new String[]{
+ List<String> argsList = new ArrayList<>(Arrays.asList(
"-f",
structPath("hdfs_with_unexist_core_site_path/struct.json"),
"-s",
configPath("hdfs_with_unexist_core_site_path/schema.groovy"),
"-g", GRAPH,
"-h", SERVER,
"--batch-insert-threads", "2",
"--test-mode", "true"
- };
+ ));
+ argsList.addAll(Arrays.asList("--username", "admin", "--password",
"pa"));
+
+
Review Comment:
Extra blank line added unnecessarily. This creates inconsistent spacing
compared to similar code blocks elsewhere in the file.
```suggestion
```
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/FileLoadTest.java:
##########
@@ -2243,16 +2252,20 @@ public void testReloadJsonFailureFiles() throws
IOException,
"\"vadas1\", \"date\": \"2013-02-20 13:00:00\"," +
"\"weight\": 1.0}");
- String[] args = new String[]{
+ List<String> argsList = new ArrayList<>(Arrays.asList(
"-f", structPath("reload_json_failure_files/struct.json"),
"-s", configPath("reload_json_failure_files/schema.groovy"),
"-g", GRAPH,
"-h", SERVER,
"--check-vertex", "true",
"--batch-insert-threads", "2",
"--test-mode", "false"
- };
- HugeGraphLoader loader = new HugeGraphLoader(args);
+ ));
+
+ argsList.addAll(Arrays.asList("--username", "admin", "--password",
"pa"));
+
+ HugeGraphLoader loader = new HugeGraphLoader(argsList.toArray(new
String[0]));
+
Review Comment:
Extra blank line added unnecessarily, creating inconsistent spacing compared
to the pattern used at lines 2063-2065.
```suggestion
HugeGraphLoader loader = new HugeGraphLoader(argsList.toArray(new
String[0]));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
