imbajin commented on code in PR #687:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/687#discussion_r2480387990
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/LoadTest.java:
##########
@@ -146,12 +146,27 @@ public static void assertDateEquals(String expectDate,
TimeZone expectZone, Stri
Assert.assertEquals(expectTimeStamp, actualTimeStamp);
}
+ /**
+ * Entry point for running the HugeGraphLoader with authentication
parameters.
+ * This method appends authentication arguments (username and password) to
the
+ * provided command-line arguments and then invokes {@link
HugeGraphLoader#main(String[])}
+ * to start the data loading process.
+ * Specifically, it appends:
+ * --username admin
+ * --password pa
+ * to the end of the original argument list before delegating to
HugeGraphLoader.
Review Comment:
⚠️ **代码质量 - LoadTest.authmain() 中的密码硬编码与注释不一致**
在 LoadTest.java 中,`authmain` 方法的 JavaDoc 注释说明密码是 `admin`,但实际代码中密码是 `pa`:
```java
// 注释中写的是:
// --password admin
// 但代码实际是:
list.add("pa");
```
**问题:**
- 注释与代码不一致,会误导开发者
- 虽然这次 PR 修正了代码(从 "admin" 改为 "pa"),但忘记更新注释
**建议:**
更新 JavaDoc 注释中的密码说明:
```suggestion
* --password pa
```
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/LoadTest.java:
##########
@@ -146,12 +146,27 @@ public static void assertDateEquals(String expectDate,
TimeZone expectZone, Stri
Assert.assertEquals(expectTimeStamp, actualTimeStamp);
}
+ /**
+ * Entry point for running the HugeGraphLoader with authentication
parameters.
+ * This method appends authentication arguments (username and password) to
the
+ * provided command-line arguments and then invokes {@link
HugeGraphLoader#main(String[])}
+ * to start the data loading process.
+ * Specifically, it appends:
+ * --username admin
+ * --password pa
+ * to the end of the original argument list before delegating to
HugeGraphLoader.
+ * @param args the original command-line arguments passed to the program.
+ * These arguments are extended with authentication information
+ * before being passed to {@code HugeGraphLoader.main()}.
+ *
+ * @see HugeGraphLoader#main(String[])
+ */
public static void authmain(String[] args) {
ArrayList list = new ArrayList(Arrays.asList(args));
Review Comment:
🧹 **代码风格 - 可以简化泛型声明**
这行代码可以使用菱形操作符简化:
```suggestion
ArrayList list = new ArrayList<>(Arrays.asList(args));
```
或者更好的做法是添加类型参数:
```java
ArrayList<String> list = new ArrayList<>(Arrays.asList(args));
```
这样可以:
1. 避免原始类型警告
2. 提供更好的类型安全性
3. 代码更清晰易读
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
