imbajin commented on code in PR #2888:
URL:
https://github.com/apache/incubator-hugegraph/pull/2888#discussion_r2554955013
##########
hugegraph-server/hugegraph-mysql/src/main/java/org/apache/hugegraph/backend/store/mysql/MysqlStore.java:
##########
@@ -54,7 +54,6 @@ public abstract class MysqlStore extends
AbstractBackendStore<Session> {
private final BackendStoreProvider provider;
private final Map<HugeType, MysqlTable> tables;
Review Comment:
🧹 **Minor: Unnecessary whitespace change**
This blank line removal is an unrelated formatting change. Please keep
formatting changes separate from functional fixes to make code reviews easier.
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/mysql/MysqlTest.java:
##########
@@ -0,0 +1,43 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.hugegraph.unit.mysql;
+
+import org.apache.hugegraph.backend.store.BackendStore;
+import org.apache.hugegraph.testutil.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+public class MysqlTest extends BaseMysqlUnitTest{
+ @Before
+ public void setUp(){
Review Comment:
⚠️ **Important: Inconsistent test lifecycle annotations**
The `setUp()` method in `MysqlTest` calls `super.setup()`, but the base
class method `setup()` doesn't have `@Before` annotation. This means:
1. The base class setup runs for every test in MysqlTest (due to @Before
here)
2. But may not run correctly for other test classes extending
BaseMysqlUnitTest
3. The naming inconsistency (`setup` vs `setUp`) is confusing
```suggestion
// Either add @Before to the base class setup() method, or rename for
consistency:
@Before
public void setup() {
super.setup();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
