Copilot commented on code in PR #2888:
URL:
https://github.com/apache/incubator-hugegraph/pull/2888#discussion_r2601697153
##########
hugegraph-server/hugegraph-mysql/src/main/java/org/apache/hugegraph/backend/store/mysql/MysqlStore.java:
##########
@@ -345,6 +345,14 @@ protected Collection<MysqlTable> tables() {
return this.tables.values();
}
+ protected Collection<MysqlTable> getTruncatedTables() {
+ // Exclude meta table to preserve system metadata during graph clear
+ return this.tables.entrySet().stream()
+ .filter(e -> !(HugeType.META == e.getKey()))
Review Comment:
[nitpick] The comparison `!(HugeType.META == e.getKey())` is unconventional.
Consider using the more natural form: `e.getKey() != HugeType.META`
```suggestion
.filter(e -> e.getKey() != HugeType.META)
```
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/UnitTestSuite.java:
##########
@@ -130,6 +132,8 @@
/* mysql */
MysqlUtilTest.class,
WhereBuilderTest.class,
+ BaseMysqlUnitTest.class,
Review Comment:
`BaseMysqlUnitTest` doesn't contain any test methods (no `@Test`
annotations), so it shouldn't be included in the test suite. Only concrete test
classes like `MysqlTest` should be registered here. Consider removing this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
