imbajin commented on code in PR #2911:
URL:
https://github.com/apache/incubator-hugegraph/pull/2911#discussion_r2576109608
##########
hugegraph-server/hugegraph-hbase/src/main/java/org/apache/hugegraph/backend/store/hbase/HbaseStore.java:
##########
@@ -114,6 +114,13 @@ protected List<String> tableNames() {
.collect(Collectors.toList());
}
+ protected List<String> truncatedTableNames() {
+ return this.tables.entrySet().stream()
+ .filter(e -> !(HugeType.META == e.getKey()))
Review Comment:
‼️ **Critical: Potential NullPointerException**
The filter condition `HugeType.META == e.getKey()` may not correctly handle
null keys, though this is unlikely in practice. However, the main concern is
whether `HugeType.META` is actually the correct type to filter out.
Consider adding a comment explaining why META type should be preserved
during truncation to improve code maintainability.
```suggestion
protected List<String> truncatedTableNames() {
// Exclude META table to preserve system metadata (e.g., version
info) during graph clear
return this.tables.entrySet().stream()
.filter(e -> !(HugeType.META == e.getKey()))
.map(e -> e.getValue().table())
.collect(Collectors.toList());
}
```
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/hbase/BaseHbaseUnitTest.java:
##########
@@ -0,0 +1,63 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.hugegraph.unit.hbase;
+
+import org.apache.commons.configuration2.Configuration;
+import org.apache.hugegraph.backend.store.hbase.HbaseSessions;
+import org.apache.hugegraph.backend.store.hbase.HbaseStoreProvider;
+import org.apache.hugegraph.config.HugeConfig;
+import org.apache.hugegraph.testutil.Utils;
+import org.apache.hugegraph.unit.BaseUnitTest;
+import org.junit.After;
+
+import java.io.IOException;
+
+public class BaseHbaseUnitTest extends BaseUnitTest{
+
+ private static final String GRAPH_NAME = "test_graph";
+
+ protected HugeConfig config;
+ protected HbaseStoreProvider provider;
+ protected HbaseSessions sessions;
Review Comment:
⚠️ **Missing `@Before` annotation**
The method is named `setup()` but the annotation `@Before` is missing. JUnit
won't automatically call this method before each test. This could cause tests
to fail or behave unexpectedly.
```suggestion
@Before
public void setup() throws IOException {
```
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/hbase/BaseHbaseUnitTest.java:
##########
@@ -0,0 +1,63 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.hugegraph.unit.hbase;
+
+import org.apache.commons.configuration2.Configuration;
+import org.apache.hugegraph.backend.store.hbase.HbaseSessions;
+import org.apache.hugegraph.backend.store.hbase.HbaseStoreProvider;
+import org.apache.hugegraph.config.HugeConfig;
+import org.apache.hugegraph.testutil.Utils;
+import org.apache.hugegraph.unit.BaseUnitTest;
+import org.junit.After;
+
+import java.io.IOException;
+
+public class BaseHbaseUnitTest extends BaseUnitTest{
+
+ private static final String GRAPH_NAME = "test_graph";
+
+ protected HugeConfig config;
+ protected HbaseStoreProvider provider;
+ protected HbaseSessions sessions;
+
+ public void setup() throws IOException {
+ Configuration conf = Utils.getConf();
+ this.config = new HugeConfig(conf);
+ this.provider = new HbaseStoreProvider();
+ this.provider.open(GRAPH_NAME);
+ this.provider.loadSystemStore(config).open(config);
+ this.provider.loadGraphStore(config).open(config);
+ this.provider.loadSchemaStore(config).open(config);
+ this.provider.init();
+ this.sessions = new HbaseSessions(config,GRAPH_NAME,
this.provider.loadGraphStore(config).store());
Review Comment:
⚠️ **Naming inconsistency: `down()` should be `tearDown()`**
The cleanup method should follow JUnit naming conventions and be named
`tearDown()` to match the common pattern.
```suggestion
@After
public void tearDown() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
