imbajin commented on code in PR #2911: URL: https://github.com/apache/incubator-hugegraph/pull/2911#discussion_r2601676521
########## hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/hbase/BaseHbaseUnitTest.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hugegraph.unit.hbase; + +import org.apache.commons.configuration2.Configuration; +import org.apache.hugegraph.backend.store.hbase.HbaseSessions; +import org.apache.hugegraph.backend.store.hbase.HbaseStoreProvider; +import org.apache.hugegraph.config.HugeConfig; +import org.apache.hugegraph.testutil.Utils; +import org.apache.hugegraph.unit.BaseUnitTest; +import org.junit.After; +import org.junit.Before; + +import java.io.IOException; + +public class BaseHbaseUnitTest extends BaseUnitTest { + + private static final String GRAPH_NAME = "test_graph"; + + protected HugeConfig config; + protected HbaseStoreProvider provider; + protected HbaseSessions sessions; + + @Before + public void setup() throws IOException { + Configuration conf = Utils.getConf(); + this.config = new HugeConfig(conf); + this.provider = new HbaseStoreProvider(); + this.provider.open(GRAPH_NAME); + this.provider.loadSystemStore(config).open(config); + this.provider.loadGraphStore(config).open(config); + this.provider.loadSchemaStore(config).open(config); + this.provider.init(); Review Comment: ⚠️ **Missing import statement** The test class uses `LOG` but doesn't import `org.slf4j.Logger` or `org.slf4j.LoggerFactory`. Either: 1. Add proper SLF4J imports and initialize LOG, or 2. Remove LOG usage if BaseUnitTest already provides it Verify the test compiles successfully. ########## hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/hbase/BaseHbaseUnitTest.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hugegraph.unit.hbase; + +import org.apache.commons.configuration2.Configuration; +import org.apache.hugegraph.backend.store.hbase.HbaseSessions; +import org.apache.hugegraph.backend.store.hbase.HbaseStoreProvider; +import org.apache.hugegraph.config.HugeConfig; +import org.apache.hugegraph.testutil.Utils; +import org.apache.hugegraph.unit.BaseUnitTest; +import org.junit.After; +import org.junit.Before; + +import java.io.IOException; + +public class BaseHbaseUnitTest extends BaseUnitTest { + + private static final String GRAPH_NAME = "test_graph"; + + protected HugeConfig config; + protected HbaseStoreProvider provider; + protected HbaseSessions sessions; + + @Before + public void setup() throws IOException { + Configuration conf = Utils.getConf(); + this.config = new HugeConfig(conf); + this.provider = new HbaseStoreProvider(); Review Comment: ‼️ **Critical: Potential resource leak in setup()** If any exception occurs after opening stores but before `sessions.open()`, the opened stores won't be properly closed. This can lead to resource leaks in test execution. ```suggestion @Before public void setup() throws IOException { Configuration conf = Utils.getConf(); this.config = new HugeConfig(conf); this.provider = new HbaseStoreProvider(); try { this.provider.open(GRAPH_NAME); this.provider.loadSystemStore(config).open(config); this.provider.loadGraphStore(config).open(config); this.provider.loadSchemaStore(config).open(config); this.provider.init(); this.sessions = new HbaseSessions(config, GRAPH_NAME, this.provider.loadGraphStore(config).store()); this.sessions.open(); } catch (Exception e) { tearDown(); throw e; } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
