bitflicker64 commented on PR #2941: URL: https://github.com/apache/incubator-hugegraph/pull/2941#issuecomment-3785563700
- The PR adds a `safeRun()` wrapper around the worker so `latch.countDown()` is guaranteed in a `finally` block. This is mainly to prevent `await()` from hanging if a worker fails early. - Context propagation still needs to be preserved properly, so `ContextCallable` should be created/wrapped at submission time in `start()` , not inside the worker thread. - avoid `catch(Throwable)` in `runAndDone()` since that would also catch `Error` (OOM/StackOverflow etc.). Keeping it to `catch(Exception)` matches the original behavior. - Also making sure `exceptionHandle()` isn’t called redundantly for the same failure path, and tweaking the log message to something accurate (failure can be inside ContextCallable wrapper too, not strictly “before runAndDone”). I’ll work on the test for where ContextCallable fails before entering runAndDone(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
