imbajin commented on PR #2941: URL: https://github.com/apache/incubator-hugegraph/pull/2941#issuecomment-3798144934
> > > Side note: there is another `Consumers` implementation at `hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/job/algorithm/Consumers.java` which also submits `ContextCallable` directly. It may have the same latch/await hang corner case. I didn’t include it here to keep this PR focused, but I can open a separate PR to apply the same fix there if you want. > > > > > > No need to update the another one (but we could merge them into one class/method reference) > > When you said “no need to update the another one (but we could merge them into one class/method reference)”, did you mean that this PR should stay limited to the current Consumers, and that any fix for the other implementation should be handled separately possibly as a later refactor to share the common logic? Exactly! You got it. We want to avoid code duplication across the project—ideally, these utilities should only exist in one place. If they need to be shared(across multi-modules), we can move them to `hugegraph-commons` in a later refactor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
