contrueCT opened a new pull request, #2991:
URL: https://github.com/apache/hugegraph/pull/2991
<!--
Thank you very much for contributing to Apache HugeGraph, we are happy
that you want to help us improve it!
Here are some tips for you:
1. If this is your first time, please read the [contributing
guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
2. If a PR fix/close an issue, type the message "close xxx" (xxx is the
link of related
issue) in the content, GitHub will auto link it (Required)
3. Name the PR title in "Google Commit Format", start with "feat | fix |
perf | refactor | doc | chore",
such like: "feat(core): support the PageRank algorithm" or "fix: wrong
break in the compute loop" (module is optional)
skip it if you are unsure about which is the best component.
4. One PR address one issue, better not to mix up multiple issues.
5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click
it directly after
published)
-->
## Purpose of the PR
- fix #2934 <!-- or use "fix #xxx", "xxx" is the ID-link of related issue,
e.g: close #1024 -->
This PR fixes HugeGraph's inconsistent handling of boolean range predicates
and unifies the internal ordering semantics as false < true. Previously,
filter-step queries such as where(__.has("xxx", P.lt(true))) were pushed down
through HugeGraph's condition/query pipeline and incorrectly treated as
numeric-style range conditions, while equivalent match() queries could still
return results normally. As a result, semantically equivalent traversals
behaved differently.
<!--
Please explain more context in this section, clarify why the changes are
needed.
e.g:
- If you propose a new API, clarify the use case for a new API.
- If you fix a bug, you can clarify why it is a bug, and should be
associated with an issue.
-->
## Main Changes
The fix has two parts. First, boolean support is added to backend condition
comparison and range-flattening logic so gt/gte/lt/lte can be evaluated
consistently. Second, runtime Gremlin boolean range predicates are normalized
into equivalent eq/in/empty conditions before query planning, so they are no
longer misclassified as ordinary numeric range queries that require a range
index. This preserves the intended boolean ordering semantics while making
has(), where(), and match() behave consistently for boolean range predicates.
<!-- Please clarify what changes you are proposing. The purpose of this
section is to outline the changes and how this PR fixes the issue. These change
logs are helpful for better and faster reviews.)
For example:
- If you introduce a new feature, please show detailed design here or add
the link of design documentation.
- If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
- If there is a discussion in the mailing list, please add the link. -->
## Verifying these changes
Regression coverage was also added for:
- low-level boolean lt/lte/gt/gte comparison semantics
- boolean range merge and conflicting-range flattening
- end-to-end consistency across has(), where(), and match()
- empty-result edge cases such as lt(false) and gt(true)
<!-- Please pick the proper options below -->
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests
here)*.
- [x] Need tests and can be verified as follows:
- mvn -Drat.skip=true -P core-test,memory -pl
hugegraph-server/hugegraph-test,hugegraph-struct -am -DfailIfNoTests=false
'-Dtest=ConditionTest,ConditionQueryFlattenTest,EdgeCoreTest#testQueryEdgeByBooleanRangePredicate'
clean test
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Dependencies ([add/update
license](https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses)
info &
[regenerate_known_dependencies.sh](../install-dist/scripts/dependency/regenerate_known_dependencies.sh))
<!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both
in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
- [x] Nope
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [x] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
