lokidundun opened a new pull request, #724:
URL: https://github.com/apache/hugegraph-toolchain/pull/724
<!--
Thank you very much for contributing to Apache HugeGraph, we are happy
that you want to help us improve it!
Here are some tips for you:
1. If this is your first time, please read the [contributing
guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
2. If a PR fix/close an issue, type the message "close xxx" (xxx is the
link of related
issue) in the content, GitHub will auto link it (Required)
3. Name the PR title in "Google Commit Format", start with "feat | fix |
perf | refactor | doc | chore",
such like: "feat(core): support the PageRank algorithm" or "fix: wrong
break in the compute loop" (module is optional)
skip it if you are unsure about which is the best component.
4. One PR address one issue, better not to mix up multiple issues.
5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click
it directly after
published)
-->
## Purpose of the PR
- close #723 <!-- or use "fix #xxx", "xxx" is the ID-link of related issue,
e.g: close #1024 -->
<!--
Please explain more context in this section, clarify why the changes are
needed.
e.g:
- If you propose a new API, clarify the use case for a new API.
- If you fix a bug, you can clarify why it is a bug, and should be
associated with an issue.
-->
## Main Changes
<!-- Please clarify what changes you are proposing. The purpose of this
section is to outline the changes and how this PR fixes the issue. These change
logs are helpful for better ant faster reviews.)
For example:
- If you introduce a new feature, please show detailed design here or add
the link of design documentation.
- If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
- If there is a discussion in the mailing list, please add the link. -->
1. .github/workflows/loader-ci.yml
- Migrated MySQL to GitHub Actions services: Adopted the official
`mysql:5.7` container service with health check configured. This eliminates the
need to execute `docker pull` and `docker run` for every workflow run.
- Added Hadoop caching: Cached `~/hadoop-2.8.5.tar.gz` with a fixed cache
key `hadoop-2.8.5`.
- Added HugeGraph Server caching: Cached `~/hugegraph-cache-${{
env.COMMIT_ID }}`; the cache key contains the commit ID to enable
auto-invalidation when the version changes.
- Removed the invocation of `install-mysql.sh`: MySQL is now provisioned
by GitHub Actions services.
2. hugegraph-loader/assembly/travis/install-hadoop.sh
- Added local installation & cache validation: Skip re-download/extraction
if `/usr/local/hadoop` already exists; use the cached tar.gz file directly if
it exists (while the local directory is missing) to avoid repeated downloads
from archive.apache.org.
- Added writes to `GITHUB_ENV`: Ensure subsequent steps can correctly
obtain `HADOOP_HOME` and `PATH` environment variables.
- Made configuration writes idempotent: Only write `core-site.xml` and
`hdfs-site.xml` if the configuration files do not exist or their content is
mismatched.
3. hugegraph-loader/assembly/travis/install-mysql.sh
- Added idempotent check: Directly skip `docker pull` and `docker run` if
the `mysql:5.7` container is already running (e.g., provided by GitHub Actions
services).
4. hugegraph-loader/assembly/travis/install-hugegraph-from-source.sh
- Added build caching: Check if the packaged `apache-hugegraph-*.tar.gz`
exists in `~/hugegraph-cache-${COMMIT_ID}` before building. Use the cached
tarball directly and skip the time-consuming `git clone` + `mvn package` if it
exists; copy the tarball to the cache directory for reuse in future runs after
the build if it does not exist.
## Verifying these changes
<!-- Please pick the proper options below -->
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests
here)*.
- [ ] Need tests and can be verified as follows:
- xxx
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to
add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module)
-->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [ ] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
