contrueCT opened a new pull request, #2993:
URL: https://github.com/apache/hugegraph/pull/2993
<!--
Thank you very much for contributing to Apache HugeGraph, we are happy
that you want to help us improve it!
Here are some tips for you:
1. If this is your first time, please read the [contributing
guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
2. If a PR fix/close an issue, type the message "close xxx" (xxx is the
link of related
issue) in the content, GitHub will auto link it (Required)
3. Name the PR title in "Google Commit Format", start with "feat | fix |
perf | refactor | doc | chore",
such like: "feat(core): support the PageRank algorithm" or "fix: wrong
break in the compute loop" (module is optional)
skip it if you are unsure about which is the best component.
4. One PR address one issue, better not to mix up multiple issues.
5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click
it directly after
published)
-->
## Purpose of the PR
- fix #2930
- fix #2931
- fix #2932 <!-- or use "fix #xxx", "xxx" is the ID-link of related issue,
e.g: close #1024 -->
This PR fixes the same negative-bound optimization bug family behind #2930,
#2931, and #2932.
HugeGraph currently inherits TinkerPop 3.5.1's `CountStrategy` optimization
for `count().is(P)`.
That optimization is not semantics-safe when the predicate uses negative
bounds, because `count()` can never be negative.
As a result:
- `count().is(P.lt(-3))` should always be `false`, but may be rewritten into
`not(...)`
- connective predicates such as `P.outside(-3, -5)` may also be optimized
incorrectly
- `count().is(P.gte(-3))` may generate a negative `RangeGlobalStep`, which
HugeGraph then extracts into an invalid backend range like `[0, -3)`
<!--
Please explain more context in this section, clarify why the changes are
needed.
e.g:
- If you propose a new API, clarify the use case for a new API.
- If you fix a bug, you can clarify why it is a bug, and should be
associated with an issue.
-->
## Main Changes
This PR introduces a HugeGraph-local `HugeCountStrategy` and replaces the
default TinkerPop `CountStrategy` registration.
The local strategy adds two protections:
1. Skip `not()` / dismiss-style optimizations when `count().is(P)` contains
negative compare bounds
2. Skip range optimization when the computed upper bound is negative, so
HugeGraph won't extract an invalid backend range
This keeps the fix scoped to HugeGraph without waiting for a full TinkerPop
upgrade, while preserving the existing optimization behavior for normal
non-negative cases.
<!-- Please clarify what changes you are proposing. The purpose of this
section is to outline the changes and how this PR fixes the issue. These change
logs are helpful for better and faster reviews.)
For example:
- If you introduce a new feature, please show detailed design here or add
the link of design documentation.
- If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
- If there is a discussion in the mailing list, please add the link. -->
## Verifying these changes
Added regression coverage for negative-bound cases in
`CountStrategyCoreTest`, including:
- `where(...count().is(P.lt(-3)))`
- `where(...count().is(P.outside(-3, -5)))`
- `repeat(...).until(...count().is(P.lt(-1)))`
- `where(...count().is(P.within(-3, -5)))`
- `where(...count().is(P.gte(-3)))`
<!-- Please pick the proper options below -->
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests
here)*.
- [x] Need tests and can be verified as follows:
- mvn -pl hugegraph-server/hugegraph-test -am -P core-test,memory \
-Dtest=CountStrategyCoreTest -DfailIfNoTests=false \
-Drat.skip=true -Dcheckstyle.skip=true test
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Dependencies ([add/update
license](https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses)
info &
[regenerate_known_dependencies.sh](../install-dist/scripts/dependency/regenerate_known_dependencies.sh))
<!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both
in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
- [x] Nope
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [x] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
