imbajin commented on PR #2997: URL: https://github.com/apache/hugegraph/pull/2997#issuecomment-4274445047
⚠️ **`commitAsync()` bypasses retry — still calls `this.session.executeAsync(s)` directly** The PR wraps `execute()` and `commit()` with `executeWithRetry`, but `commitAsync()` (line 177 in the base file) still calls `this.session.executeAsync(s)` directly. If a Cassandra restart happens during an async batch commit, the same connectivity failure will surface without any retry. Consider wrapping the async path as well, or at minimum adding a TODO/comment explaining why async commits are deliberately left un-retried (e.g., if retry semantics for async batches are too complex for this PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
