dpol1 commented on PR #2997: URL: https://github.com/apache/hugegraph/pull/2997#issuecomment-4320210853
Going through the feedback — NPE in `commitAsync()` when session is unavailable, TODO pointing to wrong type (`CompletableFuture` → Datastax `ResultSetFuture`), `reset()` not actually called on heatlh-check failure, catch too broad, `reset()` on every transient failure, idempotency check missing for `OperationTimedOutException` retries. Unit tests for all of it. Pushing soon. Quick question before I do: worth renaming `cassandra.reconnect_max_retries` / `cassandra.reconnect_interval` to `cassandra.query_retry_max_attempts` / `cassandra.query_retry_interval`? The current names bleed into `ExponentialReconnectionPolicy` semantics. Keys are new in this PR so cost is low — but happy to leave it if you want to keep the diff minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
