imbajin commented on code in PR #3008:
URL: https://github.com/apache/hugegraph/pull/3008#discussion_r3187078201
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManagerV2.java:
##########
@@ -1510,6 +1516,195 @@ public HugeGroup findGroup(String name) {
return result;
}
+ @Override
+ public void setDefaultGraph(String graphSpace, String graph, String user) {
+ try {
+ HugeBelong belong = new HugeBelong(graphSpace,
+ IdGenerator.of(user),
+ IdGenerator.of(graph +
+
DEFAULT_SETTER_ROLE_KEY));
+ this.tryInitDefaultGraph(graphSpace, graph);
+ this.updateCreator(belong);
+ belong.create(belong.update());
+ this.metaManager.createBelong(graphSpace, belong);
+ this.invalidateUserCache();
+ } catch (Exception e) {
+ throw new HugeException("Exception occurs when " +
+ "set default graph", e);
+ }
+ }
+
+ @Override
+ public void unsetDefaultGraph(String graphSpace, String graph, String
user) {
+ String role = graph + DEFAULT_SETTER_ROLE_KEY;
+ String belongId = this.metaManager.belongId(user, role);
+ Id id = IdGenerator.of(belongId);
+ // Check if belong exists before attempting to delete to make this
operation idempotent
+ if (!this.metaManager.existBelong(graphSpace, id)) {
+ // Already unset, treat as success (idempotent behavior)
+ return;
+ }
+ try {
+ this.metaManager.deleteBelong(graphSpace, id);
+ this.invalidateUserCache();
+ } catch (Exception e) {
+ throw new HugeException("Exception occurs when unset default " +
+ "graph", e);
+ }
+ }
+
+ @Override
+ public Map<String, Date> getDefaultGraph(String graphSpace, String user) {
+ List<HugeBelong> belongs = this.listBelongBySource(graphSpace,
+
IdGenerator.of(user),
+ HugeBelong.UR, -1);
+ Map<String, Date> map = new HashMap<>();
+ for (HugeBelong belong : belongs) {
+ String role = belong.target().asString();
+ if (role.endsWith(DEFAULT_SETTER_ROLE_KEY) &&
+ role.length() != DEFAULT_SETTER_ROLE_KEY.length()) {
+ map.put(role.substring(0, role.lastIndexOf(
+ DEFAULT_SETTER_ROLE_KEY)), belong.update());
+ }
+ }
+ return map;
+ }
+
+ @Override
+ public Id createDefaultRole(String graphSpace, String owner,
+ HugeDefaultRole role, String graph) {
+ String roleName = (role.isGraphRole()) ?
+ getGraphDefaultRole(graph, role.toString()) : role.toString();
+ try {
+ HugeBelong belong;
+ if (HugeGroup.isGroup(owner)) {
+ belong = new HugeBelong(graphSpace, null,
+ IdGenerator.of(owner),
+ IdGenerator.of(roleName),
+ HugeBelong.GR);
+ } else {
+ belong = new HugeBelong(graphSpace, IdGenerator.of(owner),
+ null, IdGenerator.of(roleName),
+ HugeBelong.UR);
+ }
+
+ this.tryInitDefaultRole(graphSpace, roleName, graph);
+ this.updateCreator(belong);
+ belong.create(belong.update());
+ Id result = this.metaManager.createBelong(graphSpace, belong);
Review Comment:
‼️ **Bug: default role creation is not idempotent in PD mode**
This has the same `createBelong()` issue as default graph: assigning the
same default role twice to the same user/group will fail because the belong
record already exists. Hubble-side retries or duplicate clicks should not turn
an already-set role into a server error. Please check `existBelong()` before
create, or update/no-op when the binding is already present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
